trac.webkit.orgTimeline – WebKit

Search: Login Preferences Register Forgot your password? Wiki Timeline Browse Source Search Context Navigation ← Previous Period Next Period → Timeline View changes from going back days by author Repository changesets Wiki changes Jul 20, 2020: Today 3:26 AM Changeset in webkit [264595] by commit-queue@webkit.org 5 edits in trunk [GStreamer] ImageDecoder hits more Debug ASSERTs ​ https://bugs.webkit.org/show_bug.cgi?id=214191 Patch by Philippe Normand < ​ pnormand@igalia.com > on 2020-07-20 Reviewed by Xabier Rodriguez-Calvar. Source/WebCore: Process decoded video samples from the decoder parent thread, in order to guarantee the underlying RefPtrs stored in the ImageDecoderGStreamerSample keep a consistent owning runloop. platform/graphics/gstreamer/ImageDecoderGStreamer.cpp: (WebCore::ImageDecoderGStreamer::InnerDecoder::connectDecoderPad): (WebCore::ImageDecoderGStreamer::setHasEOS): (WebCore::ImageDecoderGStreamer::notifySample): (WebCore::ImageDecoderGStreamer::InnerDecoder::handleMessage): (WebCore::ImageDecoderGStreamer::pushEncodedData): platform/graphics/gstreamer/ImageDecoderGStreamer.h: LayoutTests: platform/glib/TestExpectations: Unflag no-longer-crashing tests. 2:40 AM Changeset in webkit [264594] by Philippe Normand 2 edits in trunk/LayoutTests Unreviewed, GTK gardening platform/gtk/TestExpectations: Unflag now-stable webrtc tests, no longer flaky since r263836 . 1:37 AM Changeset in webkit [264593] by Fujii Hironori 3 edits in trunk/Source/WebCore Use forward template declarations for ColorComponents instead of including ColorComponents.h ​ https://bugs.webkit.org/show_bug.cgi?id=214540 Reviewed by Darin Adler. platform/graphics/ColorMatrix.h: platform/graphics/ColorTypes.h: 1:24 AM Changeset in webkit [264592] by Carlos Garcia Campos 2 edits in trunk/Source/WebKit valgrind claims uninitialized memory when opening inspector (WebKit::InspectorBrowserAgent::enable(WTF::String&)) ​ https://bugs.webkit.org/show_bug.cgi?id=209468 Reviewed by Michael Catanzaro. Initialize m_targetAgent. UIProcess/Inspector/WebPageInspectorController.h: Jul 19, 2020: Yesterday 8:31 PM Changeset in webkit [264591] by Lauro Moura 2 edits in trunk/Source/WebCore Unreviewed, fix GTK build in Debian/LTS Like r264279 , include functional to provide std::invoke. platform/graphics/ColorUtilities.h: 8:24 PM Changeset in webkit [264590] by Lauro Moura 3 edits 6 deletes in trunk/LayoutTests [GTK][WPE] Remove some deprecated expectation files and garden failures Unreviewed test gardening. platform/glib/TestExpectations: platform/gtk/TestExpectations: platform/gtk/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-implicit-track-expected.txt: Removed. platform/gtk/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-implicit-track-expected.txt: Removed. platform/gtk/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt: Removed. platform/gtk/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt: Removed. platform/wpe/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-columns-computed-implicit-track-expected.txt: Removed. platform/wpe/imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-rows-computed-implicit-track-expected.txt: Removed. platform/wpe/imported/w3c/web-platform-tests/css/css-properties-values-api/typedom-expected.txt: Removed. platform/wpe/imported/w3c/web-platform-tests/css/css-properties-values-api/unit-cycles-expected.txt: Removed. 7:04 PM Changeset in webkit [264589] by Fujii Hironori 5 edits in trunk/Source/WebCore Unreviewed, reverting r264588 . It broke Mac port. Reverted changeset: "Use forward template declarations for ColorComponents instead of including ColorComponents.h as much as possible" ​ https://bugs.webkit.org/show_bug.cgi?id=214204 ​ https://trac.webkit.org/changeset/264588 6:51 PM Changeset in webkit [264588] by Fujii Hironori 5 edits in trunk/Source/WebCore Use forward template declarations for ColorComponents instead of including ColorComponents.h as much as possible ​ https://bugs.webkit.org/show_bug.cgi?id=214204 <rdar://problem/65414170> Unreviewed follow-up for the review feedback of r264289 . platform/graphics/ColorConversion.cpp: platform/graphics/ColorMatrix.h: platform/graphics/ColorTypes.h: platform/graphics/ColorUtilities.h: 6:42 PM Changeset in webkit [264587] by Fujii Hironori 6 edits in trunk/Source Unreviewed non-unified source build fix Source/JavaScriptCore: runtime/IntlDateTimeFormat.cpp: runtime/IntlRelativeTimeFormat.h: Source/WebCore: html/canvas/WebGLSync.cpp: html/canvas/WebGLSync.h: 6:21 PM Changeset in webkit [264586] by ggaren@apple.com 17 edits 2 deletes in trunk/Source There should be only one RunLoop Timer class ​ https://bugs.webkit.org/show_bug.cgi?id=214340 Reviewed by Darin Adler. RunLoop::Timer wins. RunLoopTimer loses. Source/WebCore: loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::tryLoadingSubstituteData): (WebCore::DocumentLoader::cancelMainResourceLoad): (WebCore::DocumentLoader::startDataLoadTimer): Deleted. Use RunLoop::dispatch instead of a timer because we have no need to control the time period or to fire more than once. Use an explicit token so that we can still cancel. loader/DocumentLoader.h: (WebCore::DocumentLoader::DataLoadToken::clear): Added an explicit token class to we can cancel a data load. loader/ResourceLoader.cpp: (WebCore::ResourceLoader::loadDataURL): page->scheduledRunLoopPairs() is never null; and if it were null, data loads would always fail. platform/network/DataURLDecoder.cpp: (WebCore::DataURLDecoder::decode): (WebCore::DataURLDecoder::DecodingResultDispatcher::dispatch): Deleted. (WebCore::DataURLDecoder::DecodingResultDispatcher::DecodingResultDispatcher): Deleted. (WebCore::DataURLDecoder::DecodingResultDispatcher::startTimer): Deleted. (WebCore::DataURLDecoder::DecodingResultDispatcher::timerFired): Deleted. No need for two code paths, now that we can just call RunLoop::dispatch. platform/network/DataURLDecoder.h: Source/WTF: WTF.xcodeproj/project.pbxproj: wtf/CMakeLists.txt: wtf/PlatformHave.h: wtf/PlatformMac.cmake: Remove RunLoopTimer. wtf/RunLoop.cpp: (WTF::RunLoop::dispatchAfter): While we're here. let's make dispatchAfter available on all platforms. We had cross-platform code, but it was factored to be needlessly platform-specific. wtf/RunLoop.h: Added a version of dispatch() that accepts a SchedulePairHashSet for Cocoa. Removed some indirection from timer stuff, since it was confusing me. Consistently named all time intervals "interval". wtf/RunLoopTimer.h: Removed. wtf/cf/RunLoopCF.cpp: (WTF::createTimer): Factored out a helper function for dispatch() to use. (WTF::RunLoop::dispatch): This function is the meat of the patch. It's the only unique functionality that RunLoopTimer used to provide. (WTF::RunLoop::TimerBase::start): Adopted helper function. (WTF::RunLoop::runForDuration): Deleted. (WTF::RunLoop::TimerBase::timerFired): Deleted. wtf/cf/RunLoopTimerCF.cpp: Removed. wtf/generic/RunLoopGeneric.cpp: (WTF::RunLoop::dispatchAfter): Deleted. Now cross-platform. wtf/glib/RunLoopGLib.cpp: (WTF::RunLoop::TimerBase::updateReadyTime): (WTF::RunLoop::TimerBase::start): (WTF::RunLoop::TimerBase::stop): (WTF::DispatchAfterContext::DispatchAfterContext): Deleted. (WTF::DispatchAfterContext::dispatch): Deleted. (WTF::RunLoop::dispatchAfter): Deleted. Now cross-platform. wtf/win/RunLoopWin.cpp: (WTF::RunLoop::TimerBase::start): (WTF::RunLoop::dispatchAfter): Deleted. Now cross-platform. 3:39 PM Changeset in webkit [264585] by weinig@apple.com 53 edits in trunk Rename Color::transparent to Color::transparentBlack to more clearly state what it is ​ https://bugs.webkit.org/show_bug.cgi?id=214522 Reviewed by Darin Adler. Source/WebCore: accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::colorValue const): accessibility/Accessibil...